-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.3.4 #486
Release 1.3.4 #486
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it need a spec bump to the Polkadot Relay Chain runtime?
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the CHANGELOG the only diff between 1.3.3 and this proposed 1.3.4 is:
Change Polkadot inflation to 120M DOT per year (#471)
So why bump and release all (unaffected) runtimes? We could bump and release only Polkadot Relay.
Yes true. We did partial bumps in the past, and it then becomes difficult to know what runtimes need to be bumped to what version on the next release. |
Releasing same runtime again but with a different spec version is not cool IMO. It adds unnecessary operational overhead to do useless runtime upgrades. I suggest we achieve what you describe by bumping all relevant runtimes to latest spec version. In this case, only Polkadot Relay gets 1.3.4. E.g. later say we want to release AH runtime, it would get 1.3.5 (and so will any other runtime that gets changes between now and then).
"what runtimes" -> check the changelog or git history |
We dont upgrade them. They are just deleted from the release page. But it makes it simpler to ctrl+f update them all.
Yea we can also do that. Will change now to get this merged. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to re-run benchmarks for MQ bump? AHK and Encointer bumps LGTM
source = "registry+https://github.com/rust-lang/crates.io-index" | ||
checksum = "20e65a37881d1998546254a5e50a1f768b3f82deabe774e750f4ea95aba8030c" | ||
checksum = "8bb779dbfd58b3a4e6a84245392fe9d8c31a746ff7c6db414e91c012663859c3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To pick up this fix for other runtimes we need to bump them too. Not sure if the fix is urgent, if the other system chains have any overweight stuck messages in the queue.
But if they don't, I don't personally think it's worth the runtime upgrade, and we can go without bumping them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Q. I think it should be fine to only bump PAH. Last time we checked it was only Hydra affected (Astar was false positive).
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
/merge |
Enabled Available commands
For more information see the documentation |
Release for the updated inflation formula from #471
This release only affects the Polkadot runtime.